This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
* CaseInsensitiveMap: added constructor fromEntries.
#99
+23
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* collection: ^1.19.0
kevmoo
approved these changes
Jun 14, 2024
|
FYI @kevmoo: Waiting only for dart-lang/shelf@master...gmpassos:shelf:CaseInsensitiveMap.fromEntries |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 14, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. collection (https://github.com/dart-lang/collection/compare/c90b19f..9354f38): 9354f38 2024-06-13 Kevin Moore Require Dart 3.4, test wasm on 3.4, prepare release (dart-archive/collection#349) http (https://github.com/dart-lang/http/compare/e2e2170..8c325b9): 8c325b9 2024-06-14 Anikate De pkgs/ok_http: Stream response bodies. (dart-lang/http#1233) http_parser (https://github.com/dart-lang/http_parser/compare/53d4041..71b4c2c): 71b4c2c 2024-06-13 Graciliano Monteiro Passos `CaseInsensitiveMap`: added constructor `fromEntries`. (dart-archive/http_parser#99) Change-Id: I0f848975241261f42e0759d00188fef12731a085 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371740 Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
mosuem
pushed a commit
to dart-lang/http
that referenced
this pull request
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CaseInsensitiveMap: added constructorfromEntries.collection: ^1.19.0
Real-world case:
Avoid unnecessary overhead as seen here:
https://github.com/dart-lang/shelf/blob/master/pkgs/shelf/lib/src/headers.dart#L32
Reason:
Improve Dart benchmark performance:
https://sharkbench.dev/web